Itinerary Body Caret Improvements #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| version "11.1.2" | ||
| resolved "https://registry.yarnpkg.com/@opentripplanner/core-utils/-/core-utils-11.1.2.tgz#a99d1fa4fb1f587d58fae8fcfd70a3bfe4eed424" | ||
| integrity sha512-Rn1tBm5F+nt/A4/0cpq6cyNTprSsxfFslujMoZ4P4r6fZ7YTx0d25di+MZ/CZgSlCzHJIiGAfi8DsfJ7yStcTA== | ||
| "@opentripplanner/geocoder@^1.4.2": |
There was a problem hiding this comment.
what's up here!
There was a problem hiding this comment.
I don't know!
| @@ -300,7 +300,9 @@ class TransitLegBody extends Component<Props, State> { | |||
| alertCount: alerts.length | |||
| }} | |||
| /> | |||
| <S.CaretToggle expanded={alertsExpanded} /> | |||
| {!shouldOnlyShowAlertsExpanded && ( | |||
There was a problem hiding this comment.
Wait doesn't shouldOnlyShowAlertsExpanded just impact how the alerts are rendered? The caret should still be there if users want to collapse them after render, right?
There was a problem hiding this comment.
That behavior doesn't work right now
amy-corson-ibigroup
approved these changes
Nov 17, 2023
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned amy-corson-ibigroup
daniel-heppner-ibigroup
approved these changes
Nov 21, 2023
| graphql "^16.6.0" | ||
| lodash.clonedeep "^4.5.0" | ||
| lodash.isequal "^4.5.0" | ||
| qs "^6.9.1" |
There was a problem hiding this comment.
wow good job cleaning up the dependencies with this pr
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The itinerary body previously showed carets when they were inoperable. This PR ensures they are only shown when it makes sense