Raise an exception when there's extra text at the end of an allele name #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end of an allele name
| @@ -131,7 +131,13 @@ def parse_allele_name(name, species_prefix=None): | |||
|
|
|||
| sep, name = parse_separator(name) | |||
|
|
|||
| allele_code, name = parse_numbers(name) | |||
| allele_code, rest_of_text = parse_numbers(name) | |||
There was a problem hiding this comment.
So the variable name on the left was incorrectly named previously?
If so, LGTM!
There was a problem hiding this comment.
I changed the name just to clarify that at this point we don't expect any subsequent characters in the allele name.
I'm on a phone, any chance you can push the new version to PyPI after I merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mhcnames seems to currently silently parse "HLA-A*02:01 C30S mutant" as just "HLA-A*02:01" (see #20). This branch makes it so any extra text at the end causes an
AlleleParseErrorexception to be raised.Future plan: support parsing of mutations at the end of an allele (related: #19)