Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for netMHCIIpan #16

Closed
wants to merge 2 commits into from
Closed

Add support for netMHCIIpan #16

wants to merge 2 commits into from

Conversation

tavinathanson
Copy link
Contributor

Some highlights:

  • netMHCIIpan expects allele names to be in a weird format, so I added some hackery that I'm not too pleased with.
  • netMHCIIpan can expect alpha/beta alleles rather than a single allele.

Review on Reviewable

@iskandr
Copy link
Contributor

iskandr commented Jul 8, 2015

Review status: 0 of 10 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.


mhctools/alleles.py, line 80 [r1] (raw file):
Since you're actually specifying a pair of allele pairs, maybe it's clearer to rename this to something like ClassIIAllelePair?

Alternatively, why not just use tuple pairs of AlleleName objects for Class II prediction?


mhctools/alleles.py, line 133 [r1] (raw file):
Can you give examples of what format is acceptable for pairs of alleles?

Also, wouldn't it be easier to move the logic for pairs out alleles out of this function and have it always return AlleleNames even for class II? Otherwise, it seems like you'll have to messily handle DR genes, which usually don't specify the DRA1 allele (often assumed to be DRA1*01:01) but might give multiple DRB genes.


mhctools/alleles.py, line 198 [r1] (raw file):
Can you explain the logic here? What is the allele expected to look like?


mhctools/base_predictor.py, line 32 [r1] (raw file):
Add this to the parameter list with a description of what we use it for?


Comments from the review on Reviewable.io

@iskandr
Copy link
Contributor

iskandr commented Aug 24, 2015

@tavinathanson Maybe revisit this PR this week?

@tavinathanson
Copy link
Contributor Author

Yup, already on it

@tavinathanson
Copy link
Contributor Author

Trumped by #29; I think I incorporated all your comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants