URL decode for windows #2957
Merged
URL decode for windows #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinowski
force-pushed
the
url-decode
branch
from
4086491 to
1d93195
Compare
dtrawins
reviewed
Jan 10, 2025
| // Check if the next two characters are valid hex digits | ||
| if (i + 2 < encoded.size() && | ||
| std::isxdigit(static_cast<unsigned char>(encoded[i + 1])) && | ||
| std::isxdigit(static_cast<unsigned char>(encoded[i + 2]))) { |
There was a problem hiding this comment.
if i + 2 >= encoded.size(), it can be a seqfault
we should add a test with encoded string test%
There was a problem hiding this comment.
if i + 2 is >= encoded.size() we are skip the if and enter else (line 1160-1163) so there wont be an issue
however, will add test for test%
dtrawins
approved these changes
Jan 13, 2025
atobiszei
reviewed
Jan 14, 2025
| expected = "model/name"; | ||
| output = ovms::urlDecode(input); | ||
| EXPECT_EQ(expected, output); | ||
| EXPECT_EQ("a b c d", ovms::urlDecode("a%20b%20c%20d")); |
dkalinowski
force-pushed
the
url-decode
branch
from
89cab63 to
39f4305
Compare
atobiszei
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Support for llm models containing "/" in a servable name
CVS-159405
🧪 Checklist