Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HETERO] Add CPU and GPU plugins to tests dependencies if exists #28428

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented Jan 14, 2025

Details:

Fix dependencies issue when hetero tests dependent on CPU and GPU plugins fail if ov_hetero_func_tests are built as the only target:

$ cmake -S . -B build -DENABLE_TESTS=ON
$ make -j$(nproc) ov_hetero_func_tests

Tickets:

  • N/A

@aobolensk aobolensk requested a review from a team as a code owner January 14, 2025 08:11
@github-actions github-actions bot added category: HETERO OpenVINO HETERO plugin category: build OpenVINO cmake script / infra labels Jan 14, 2025
@ilya-lavrenov ilya-lavrenov added this to the 2025.0 milestone Jan 14, 2025
@ilya-lavrenov
Copy link
Contributor

@peterchen-intel is it expected that HETERO tests require CPU?
As I remember, we worked on clean up of Meta plugins tests to avoid dependency on HW plugins, but not re-call whether it was finished for HETERO func tests.

@aobolensk aobolensk changed the title [HETERO] Add CPU plugin to dependencies if exists [HETERO] Add CPU plugin to tests dependencies if exists Jan 14, 2025
@zhaixuejun1993
Copy link
Contributor

@aobolensk Sorry for later, I'm trying to reproduce this issue in local,

  1. The build process succussed with only ov_hetro_func_test.
  2. Run ov_hetro_func_test failed with can not find the cpu plugin.
    Actually the nightly tests need hw plugin in the test, so if u only build the ov_hetro_func_test, the nightly* related tests can not be run.
    The correct command run ov_hetro_func_test (for the only building) is:
    ./ov_hetero_func_tests --gtest_filter=-"nightly*"
    And one more thing, I find another bug in hetro func test in the processing & fixed in this PR, pls try with this changes.
    [Hetro][Func Test] only the nightly tests can use hw plugin #28545

@aobolensk
Copy link
Contributor Author

2. Run ov_hetro_func_test failed with can not find the cpu plugin.

True, this is exactly what I see on my side. According to @ilya-lavrenov we should do that on both levels (CMake and tests):

  1. If CPU plugin is available then we need to require it to be built first (using add_dependencies in CMake) - this is what my patch does
  2. There should be a mechanism in the tests that disables CPU specific tests on gtest side for them not to be failed if CPU plugin is not found

@aobolensk
Copy link
Contributor Author

2. pls try with this changes

Sorry for the late reply, I have tried on the same environment with the latest OpenVINO (with your patch included). Some tests are still failing due to the same reason: lack of CPU device

@ilya-lavrenov ilya-lavrenov removed this from the 2025.0 milestone Jan 23, 2025
@aobolensk
Copy link
Contributor Author

Hello @zhaixuejun1993 , do you have any updates?

@aobolensk aobolensk force-pushed the hetero-wait-for-cpu-plugin branch from 00a1296 to c3f2e35 Compare February 11, 2025 07:41
@aobolensk aobolensk changed the title [HETERO] Add CPU plugin to tests dependencies if exists [HETERO] Add CPU and GPU plugins to tests dependencies if exists Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: build OpenVINO cmake script / infra category: HETERO OpenVINO HETERO plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants