Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Deprecate undefined type and use dynamic where possible #28766

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[core] Deprecate undefined type and use dynamic where possible #28766

wants to merge 3 commits into from
+4,099 −4,626

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Jan 31, 2025

Details:

  • Mark ov::element::undefined as deprecated
  • Use dynamic type instead of undefined

Tickets:

@praasz praasz requested review from a team as code owners January 31, 2025 14:33
@praasz praasz requested review from ilya-lavrenov and itikhono and removed request for a team January 31, 2025 14:33
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin labels Jan 31, 2025
@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: Python API OpenVINO Python bindings category: C API OpenVINO C API bindings category: transformations OpenVINO Runtime library - Transformations category: LP transformations OpenVINO Low Precision transformations category: samples OpenVINO Runtime Samples category: IR FE OpenVINO IR v10 / v11 FrontEnd category: TEMPLATE OpenVINO Template plugin category: ONNX FE OpenVINO ONNX FrontEnd category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: TF FE OpenVINO TensorFlow FrontEnd category: CPP API OpenVINO CPP API bindings category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: NPU OpenVINO NPU plugin labels Jan 31, 2025
akuporos
akuporos reviewed Jan 31, 2025
View reviewed changes
src/bindings/python/src/pyopenvino/graph/types/element_type.cpp
@@ -31,7 +31,7 @@ void regclass_graph_Type(py::module m) {
:rtype: ov.Type
)");

type.attr("undefined") = ov::element::undefined;
type.attr("undefined") = ov::element::dynamic;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that deprecation warning is also thrown for Python API?

praasz added 2 commits January 31, 2025 15:58
@praasz
Apply code style
c598fce 
Signed-off-by: Pawel Raasz <[email protected]>
@praasz
Fix deprecation in element type
947aeb6 
Signed-off-by: Pawel Raasz <[email protected]>
@github-actions github-actions bot added the category: NPUW NPUW plugin label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuporos akuporos akuporos left review comments

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov ilya-lavrenov is a code owner automatically assigned from openvinotoolkit/openvino-maintainers

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

@ilya-lavrenov ilya-lavrenov

@slyalin slyalin

Labels
category: C API OpenVINO C API bindings category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: IR FE OpenVINO IR v10 / v11 FrontEnd category: LP transformations OpenVINO Low Precision transformations category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin category: ONNX FE OpenVINO ONNX FrontEnd category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: Python API OpenVINO Python bindings category: samples OpenVINO Runtime Samples category: TEMPLATE OpenVINO Template plugin category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@praasz @akuporos @ilya-lavrenov @slyalin