Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] fix qkv_proj/mlp jit kernel's win32 support #28915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CPU] fix qkv_proj/mlp jit kernel's win32 support #28915

wants to merge 1 commit into from
+68 −24

Conversation

usstq
Copy link
Contributor

@usstq usstq commented Feb 11, 2025

Details:

  • MSVC on win32 platform has x64 calling conversion different from Linux, this change added a fix to jit kernel to support win32 system

Tickets:

@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Feb 11, 2025
luo-cheng2021
luo-cheng2021 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@luo-cheng2021 luo-cheng2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/plugins/intel_cpu/src/nodes/kernels/x64/mlp_kernel.cpp
Xbyak::Reg64 src1 = r8;
Xbyak::Reg64 dst = r9;
Xbyak::Reg64 prefetch_dst = r10;
Xbyak::Reg64 BN = r11;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for note: from doc: rax, rcx, rdx, r9-r11 could be used in the callee without protection.

@usstq usstq marked this pull request as ready for review February 11, 2025 07:31
@usstq usstq requested review from a team as code owners February 11, 2025 07:31
@dmitry-gorokhov dmitry-gorokhov added this to the 2025.1 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@luo-cheng2021 luo-cheng2021 luo-cheng2021 approved these changes

Assignees
No one assigned
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
3 participants
@usstq @dmitry-gorokhov @luo-cheng2021