[PT FE] Added support for aten::__lshift__ and aten::__rshift__ and aten::bitwise_left_shift and aten::bitwise_right_shift #28939
+149
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eft_shift, and aten::bitwise_right_shift with corresponding tests.
…into shiftOperations
…into shiftOperations
…3/openvino into shiftOperations
…3/openvino into shiftOperations
|
Hi @mvafin, |
rkazants
reviewed
Feb 13, 2025
|
|
||
| auto [input_tensor, shift_amount] = get_inputs_with_promoted_types(context, 0, 1); | ||
|
|
||
| auto lshift_node = context.mark_node(std::make_shared<v15::BitwiseLeftShift>(input_tensor, shift_amount)); |
There was a problem hiding this comment.
These two operations are sort of binary operations for which we do not create separate source files and translator. Please check how other binary operations are supported and support yours in the same way.
There was a problem hiding this comment.
thank you for your review,
I've started working on resolving the problem
There was a problem hiding this comment.
@rkazants I've resolved the problem
|
hi @mvafin , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: