Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] Fix tensor is_continuous method #28973

Merged
merged 2 commits into from
Feb 14, 2025
Merged

[CORE] Fix tensor is_continuous method #28973

merged 2 commits into from
Feb 14, 2025
+245 −1

Conversation

pereanub
Copy link
Contributor

@pereanub pereanub commented Feb 13, 2025 •
edited
Loading

Details:

  • If data is a contiguous memory area, return true
  • Strides can be different and data can still be contiguous in memory. Extra checks are needed in this case

Tickets:

  • E#156237

@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: NPU OpenVINO NPU plugin labels Feb 13, 2025
@ilya-lavrenov ilya-lavrenov added this to the 2025.1 milestone Feb 13, 2025
@pereanub pereanub force-pushed the fix_is_continuous_method branch from 204e479 to 30f58ad Compare February 13, 2025 12:26
@pereanub pereanub changed the title If memory is contiguous return true [CORE] Fix tensor is_continuous method Feb 13, 2025
@pereanub pereanub marked this pull request as ready for review February 13, 2025 14:11
@pereanub pereanub requested review from a team as code owners February 13, 2025 14:11
praasz
praasz reviewed Feb 14, 2025
View reviewed changes
src/core/src/runtime/itensor.cpp Outdated Show resolved Hide resolved
src/core/tests/ov_tensor_test.cpp Show resolved Hide resolved
@pereanub pereanub force-pushed the fix_is_continuous_method branch from 30f58ad to 73b10ac Compare February 14, 2025 10:49
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@pereanub pereanub added this pull request to the merge queue Feb 14, 2025
Merged via the queue into openvinotoolkit:master with commit 5755945 Feb 14, 2025
185 checks passed
@pereanub pereanub deleted the fix_is_continuous_method branch February 14, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

@praasz praasz praasz approved these changes

Assignees

@praasz praasz

Labels
category: Core OpenVINO Core (aka ngraph) category: NPU OpenVINO NPU plugin
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
3 participants
@pereanub @ilya-lavrenov @praasz