Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Fix Conflict by Replacing local_memory with shared_local_memory in sdpa_opt_finalization_stage #29083

Merged
merged 2 commits into from
Feb 21, 2025
Merged

[GPU] Fix Conflict by Replacing local_memory with shared_local_memory in sdpa_opt_finalization_stage #29083

merged 2 commits into from
Feb 21, 2025

Conversation

zaixing-wang
Copy link
Contributor

@zaixing-wang zaixing-wang commented Feb 20, 2025 •
edited by peterchen-intel
Loading

Details:

  • To replaced local_memory with shared_local_memory to prevent index conflicts and save local memory by updating the definition of max_logits_u_exp_sum.
  • To remove redundant code to improve maintainability.

Tickets:

@zaixing-wang zaixing-wang requested review from a team as code owners February 20, 2025 09:10
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Feb 20, 2025
@zaixing-wang zaixing-wang changed the title [GPU] Resolve Index Conflict by Replacing local_memory with shared_local_memory [GPU] Fix Conflict by Replacing local_memory with shared_local_memory in sdpa_opt_finalization_stage Feb 20, 2025
sungeunk
sungeunk approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@sungeunk sungeunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues are fixed. Please merge this PR.

sshlyapn
sshlyapn approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@sshlyapn sshlyapn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-durandin p-durandin enabled auto-merge February 21, 2025 09:42
@p-durandin p-durandin added this pull request to the merge queue Feb 21, 2025
Merged via the queue into openvinotoolkit:master with commit 980bdd5 Feb 21, 2025
168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshlyapn sshlyapn sshlyapn approved these changes

@sungeunk sungeunk sungeunk approved these changes

@ceciliapeng2011 ceciliapeng2011 Awaiting requested review from ceciliapeng2011

@songbell songbell Awaiting requested review from songbell

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zaixing-wang @sshlyapn @sungeunk @p-durandin @peterchen-intel