Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted credential cannot be readded to wallet #80

Closed
bmuramatsu opened this issue Dec 2, 2021 · 3 comments · Fixed by #110
Closed

Deleted credential cannot be readded to wallet #80

bmuramatsu opened this issue Dec 2, 2021 · 3 comments · Fixed by #110
Assignees
Labels
bug Schedule this bug

Comments

@bmuramatsu
Copy link
Contributor

bmuramatsu commented Dec 2, 2021

From reset wallet. Finish setup.

Add credential from digitalcredentials/docs#10 multiple credentials with invalid signature:
135905712-2e9baf4d-3489-40eb-966f-6e3da5cc2a3c

Delete second credential. Only 1 credential remains in the wallet.

Try to readd credentials using the same two from QR code.

Both credentials appear as "Aready in Wallet"

But, only 1 credential in the wallet...

@bmuramatsu bmuramatsu added the bug Schedule this bug label Dec 2, 2021
@sethduffin
Copy link
Contributor

sethduffin commented Dec 3, 2021

@bmuramatsu Thanks for the repro documentation. I've added a story in PT and will take a look at it.
https://www.pivotaltracker.com/story/show/180524965

@bmuramatsu
Copy link
Contributor Author

Appears to be resolved, I forget which PR, closing this.

@sethduffin
Copy link
Contributor

I believe this is still an issue.
We're using the id field to differentiate credentials but not all contain an id so it treats them as duplicates.
We discussed using the proofValue to identify credentials going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Schedule this bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants