Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicate credential logic #110

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

sethduffin
Copy link
Contributor

Fixes #80.

Not all credentials contain the id attribute.
The logic has been updated to use the proofValue to differentiate credentials.

Not all credentials contain the `id` attribute.
The logic has been updated to use the `proofValue` to differentiate credentials.
@sethduffin sethduffin requested a review from dittonjs January 25, 2022 00:07
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmitrizagidulin dmitrizagidulin merged commit db6eab7 into main Jan 26, 2022
@dmitrizagidulin dmitrizagidulin deleted the seth/duplicate-credential-logic branch January 26, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted credential cannot be readded to wallet
2 participants