Add a custom encoding for very large (>50mb) data #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlonbaeten
approved these changes
Jul 30, 2024
Signed-off-by: Marc Schoolderman <[email protected]>
tweedegolf-marc
force-pushed
the
big-data
branch
from
0be625c to
6344a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #40
This is achieved by a rather crude encoding which even discards identifier information; but it suffices for a PoC.
Note: this PR builds upon #41 (so that should be merged first), but can be reworked so it fits on current main without it if desired; however, since nested message unpacking involves an allocation+copy, having more than 50mb of data feels like it's a DDoS risk. The actual delta is in 6344a2e