Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Restrict Map Zoom Levels to Supported Range #331

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix: Restrict Map Zoom Levels to Supported Range #331

wants to merge 5 commits into from

Conversation

rishabhknowss
Copy link

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #188

Description of Changes

earlier the max zoom was 32 by default , now it's reduced to 18 for better viewing experience

nemesifier
nemesifier requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue description asks to allow to make this configurable, while providing a sensible default. I don't think having this is a sensible default.

@rishabhknowss
Copy link
Author

Okay, working on it

@rishabhknowss
Copy link
Author

Hello @nemesifier
I tried something to make maxZoom configurable , can you check please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Map default zoom levels seem to allow for more zoom than supported
2 participants
@rishabhknowss @nemesifier