chore: Fix bugs:

- Update aspect ratio parameter in camera functions - typing
openxrlab · Aug 5, 2024 · 7806d65 · 7806d65
1 parent 9ad1c23
commit 7806d65
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 5 deletions.
diff --git a/.circleci/Start-CircleCIRunner.ps1 b/.circleci/Start-CircleCIRunner.ps1
@@ -1,4 +1,4 @@
-$installDirPath = "$env:ProgramFiles\CircleCI"
+$installDirPath = "D:\Program Files\CircleCI"
 $agentPath = Join-Path -Path $installDirPath -ChildPath "circleci-runner.exe"
 $configPath = Join-Path -Path $installDirPath -ChildPath "runner-agent-config.yaml"
 

diff --git a/.circleci/continue_config.yml b/.circleci/continue_config.yml
@@ -70,11 +70,15 @@ jobs:
                     $env:XRFEITORIA__DIST_ROOT="$PWD/src"
                   }
                   if ($env:RUN_TEST -eq 1) {
-                    echo "#### Running Tests ####"
+                    echo "#### Running Tests For UE 5.1 ####"
                     python -m tests.setup_ci -u $UE_51
                     python -m tests.unreal.main
+
+                    echo "#### Running Tests For UE 5.2 ####"
                     python -m tests.setup_ci -u $UE_52
                     python -m tests.unreal.main
+
+                    echo "#### Running Tests For UE 5.3 ####"
                     python -m tests.setup_ci -u $UE_53
                     python -m tests.unreal.main
                   }

diff --git a/xrfeitoria/sequence/sequence_base.py b/xrfeitoria/sequence/sequence_base.py
@@ -275,7 +275,7 @@ def use_camera(
         location: 'Optional[Vector]' = None,
         rotation: 'Optional[Vector]' = None,
         fov: float = None,
-        aspect_ratio: float = None,
+        aspect_ratio: float = 16.0 / 9.0,
     ) -> None:
         """Use the specified level camera in the sequence. The location, rotation and
         fov set in this method are only used in the sequence. The location, rotation and
@@ -308,7 +308,7 @@ def use_camera_with_keys(
         camera: _camera,
         transform_keys: 'TransformKeys',
         fov: float = None,
-        aspect_ratio: float = None,
+        aspect_ratio: float = 16.0 / 9.0,
     ) -> None:
         """Use the specified level camera in the sequence. The transform_keys and fov
         set in this method are only used in the sequence. The location, rotation and fov

diff --git a/xrfeitoria/sequence/sequence_base.pyi b/xrfeitoria/sequence/sequence_base.pyi
@@ -35,14 +35,20 @@ class SequenceBase(ABC):
     ) -> ActorBase: ...
     @classmethod
     def spawn_camera(
-        cls, location: Vector = None, rotation: Vector = None, fov: float = 90.0, camera_name: Optional[str] = None
+        cls,
+        location: Vector = None,
+        rotation: Vector = None,
+        fov: float = 90.0,
+        aspect_ratio: float = 16.0 / 9.0,
+        camera_name: Optional[str] = None,
     ) -> CameraBase: ...
     @classmethod
     def spawn_camera_with_keys(
         cls,
         transform_keys: TransformKeys,
         fov: float = 90.0,
         camera_name: str = None,
+        aspect_ratio: float = 16.0 / 9.0,
     ) -> CameraBase: ...
     @classmethod
     def use_camera(
@@ -51,13 +57,15 @@ class SequenceBase(ABC):
         location: Optional[Vector] = None,
         rotation: Optional[Vector] = None,
         fov: float = None,
+        aspect_ratio: float = 16.0 / 9.0,
     ) -> None: ...
     @classmethod
     def use_camera_with_keys(
         cls,
         camera: CameraBase,
         transform_keys: TransformKeys,
         fov: float = None,
+        aspect_ratio: float = 16.0 / 9.0,
     ) -> None: ...
     @classmethod
     def use_actor(