Fix Danger Dialog regression: unable to set custom button text #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f7cd457 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
myabc
force-pushed
the
fix/custom-button-text-regression
branch
from
d578528 to
d3cf2d9
Compare
myabc
changed the title
HDinger
approved these changes
Feb 4, 2025
HDinger
reviewed
Feb 4, 2025
myabc
force-pushed
the
fix/custom-button-text-regression
branch
from
609c28f to
f7cd457
Compare
myabc
commented
Feb 4, 2025
| @@ -1,4 +1,5 @@ | |||
| <%= render(Primer::OpenProject::DangerDialog.new(id: "my-dialog", | |||
| title: "My dialog", | |||
There was a problem hiding this comment.
This line is needed to avoid Axe violations - #237 makes this param required.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes a regression in 0.53.0 where callers are unable to set custom button text for the Danger Dialog.
Screenshots
Integration
List the issues that this change affects.
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist