Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#61546] Fix DangerDialog scroll behaviour w/form + system test #244

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

myabc
Copy link

@myabc myabc commented Feb 19, 2025

⚠️ This PR is based on #243 - please review/merge that PR first.
⚠️ This PR requires an upstream enhancement to Cuprite in order for tests to run green - rubycdp/cuprite#291

What are you trying to accomplish?

Fix Danger Dialog scroll behaviour when the dialog contains a form + verify behaviour is correct with system test.

Screenshots

See #243

Integration

N/A

List the issues that this change affects.

https://community.openproject.org/wp/61546

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: 83fd601

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@myabc myabc changed the base branch from main to fix/61546-danger-dialog-scroll-behaviour February 19, 2025 00:11
@myabc myabc changed the title Fix/61546 danger dialog scroll behaviour test [#61546] Fix DangerDialog scroll behaviour w/form + system test Feb 19, 2025
@myabc myabc added bug Something isn't working work in progress Do not merge without further discussion labels Feb 19, 2025
@myabc myabc force-pushed the fix/61546-danger-dialog-scroll-behaviour-test branch from 437dd0b to 182d9eb Compare February 19, 2025 00:32
@myabc myabc force-pushed the fix/61546-danger-dialog-scroll-behaviour branch from 5c45a6f to 79986c4 Compare February 20, 2025 12:19
Base automatically changed from fix/61546-danger-dialog-scroll-behaviour to main February 20, 2025 12:39
@myabc myabc force-pushed the fix/61546-danger-dialog-scroll-behaviour-test branch from 182d9eb to 83fd601 Compare February 20, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working work in progress Do not merge without further discussion
Development

Successfully merging this pull request may close these issues.

1 participant