-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: split CI workflow and add ruff format #8
ci: split CI workflow and add ruff format #8
Conversation
- Split ci.yaml into mypy.yaml, ruff.yaml, and test.yaml - Add ruff lint command to ruff.yaml
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tranqu's ci flow is small, so it's harder to manage if the files are split up.
I think it's a good idea to add ruff format, so I'd like to keep the files as one.
I still believe there are several advantages to splitting the CI workflows: Faster Execution through Parallelization
Efficient Error Identification
Improved Maintainability
Efficient Re-runs
While the project may be small now, these advantages are significant when considering future scalability. |
Tranqu is currently a small product, so if any problems arise in the future, we would like to consider splitting the files. |
Thank you for your detailed explanation. While I still see value in workflow separation for error identification and maintainability beyond just execution time, I understand your point about the current scale of Tranqu and the potential overhead from duplicate code. Let's keep it as a single workflow file for now. We can always revisit this discussion when Tranqu grows, and the benefits of parallel execution become more significant. I'll update the PR to consolidate the workflows into a single file while adding the ruff format check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✍ Description
Split ci.yaml into three separate files for better organization:
Also added ruff format command in addition to ruff check in ruff.yaml.
This change makes it easier to manage each CI task and simplifies future maintenance.