Add Data.define #3341
Merged
Add Data.define #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Thank you, I'll take it from here. |
eregon
force-pushed
the
compat/Data.define
branch
2 times, most recently
from
f91a411 to
86be023
Compare
eregon
approved these changes
Nov 30, 2023
eregon
reviewed
Nov 30, 2023
| @@ -419,7 +419,7 @@ def pretty_print_cycle(q) # :nodoc: | |||
| class Data # :nodoc: | |||
| def pretty_print(q) # :nodoc: | |||
| q.group(1, sprintf("#<data %s", PP.mcall(self, Kernel, :class).name), '>') { | |||
| q.seplist(PP.mcall(self, Data, :members), lambda { q.text "," }) {|member| | |||
| q.seplist(PP.mcall(self, Kernel, :class).members, lambda { q.text "," }) {|member| | |||
There was a problem hiding this comment.
This is because we don't define Data#members but define it on the instance_methods_module.
I don't think it makes much sense to define it on Data as it would be a megamorphic call to members on the actual object's class.
So rather I think we should upstream this change.
eregon
force-pushed
the
compat/Data.define
branch
2 times, most recently
from
a67180e to
fb54b5e
Compare
eregon
force-pushed
the
compat/Data.define
branch
from
25437f5 to
0edc91b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new core class to represent simple immutable value object. The class is
similar to Struct and partially shares an implementation, but has more
lean and strict API. See this redmine discussion for more.
Still in an incomplete state.