Avoid excessive splitting of nodes caused by a unique proc being created per call when a method reference would suffice. #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted per call when a method reference would suffice.
oracle-contributor-agreement
bot
added
the
OCA Verified
andrykonchin
added
the
in-ci
eregon
reviewed
Apr 12, 2024
eregon
approved these changes
Apr 12, 2024
andrykonchin
force-pushed
the
reduce-proc-allocation-string-split
branch
from
70c1051 to
2d0171e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truffle::Splitter.splitwill yield each split part if a block is provided or otherwise will collect the results into an array. These code paths were unified by creating a proc toArray#<<. This approach resulted in a new proc being allocated per call, which in turn created excessive splitting ofArray#<<as reported in #3527. Since the method reference can be invoked directly, there's no need to turn it into a proc. This PR simplifies the code to eliminate that proc allocation.