Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rb_str_strlen #3699

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Implement rb_str_strlen #3699

merged 1 commit into from
Oct 29, 2024

Conversation

Th3-M4jor
Copy link
Contributor

closes #3697

@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 29, 2024
@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 29, 2024
eregon
eregon approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you.
It's just missing a CHANGELOG entry, I'll add it.

@eregon eregon changed the title implement rb_str_strlen Implement rb_str_strlen Oct 29, 2024
@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Oct 29, 2024
@eregon eregon force-pushed the implement-rb_str_strlen-cext-function branch from b5dba10 to 414e9a3 Compare October 29, 2024 14:02
@graalvmbot graalvmbot merged commit fe19a02 into oracle:master Oct 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
in-ci The PR is being tested in CI. Do not push new commits. OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symbol lookup error: rb_str_strlen
3 participants
@Th3-M4jor @eregon @graalvmbot