-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate dependency on Swing and call to invokeLater #345
Open
JaroslavTulach
wants to merge
2
commits into
oracle:master
Choose a base branch
from
JaroslavTulach:jtulach/NoSwingReference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/heap/Progress.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| /* | ||
| * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. Oracle designates this | ||
| * particular file as subject to the "Classpath" exception as provided | ||
| * by Oracle in the LICENSE file that accompanied this code. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
| package org.graalvm.visualvm.lib.jfluid.heap; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| enum Progress { | ||
| COMPUTE_INSTANCES, | ||
| COMPUTE_REFERENCES, | ||
| FILL_HEAP_TAG_BOUNDS, | ||
| COMPUTE_GC_ROOTS, | ||
| COMPUTE_RETAINED_SIZE, | ||
| COMPUTE_RETAINED_SIZE_BY_CLASS; | ||
|
|
||
| Handle start() { | ||
| return new Handle(this); | ||
| } | ||
|
|
||
| private static List<Listener> listeners = Collections.emptyList(); | ||
| synchronized static void register(Listener onChange) { | ||
| if (listeners.isEmpty()) { | ||
| listeners = Collections.singletonList(onChange); | ||
| } else { | ||
| List<Listener> copy = new ArrayList<>(listeners); | ||
| copy.add(onChange); | ||
| listeners = copy; | ||
| } | ||
| } | ||
|
|
||
| private synchronized static void notifyUpdates(Handle h, Type type) { | ||
| for (Listener onChange : listeners) { | ||
| switch (type) { | ||
| case STARTED: onChange.started(h); break; | ||
| case PROGRESS: onChange.progress(h); break; | ||
| default: onChange.finished(h); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private enum Type { | ||
| STARTED, PROGRESS, FINISHED; | ||
| } | ||
|
|
||
| static interface Listener { | ||
| void started(Handle h); | ||
| void progress(Handle h); | ||
| void finished(Handle h); | ||
| } | ||
|
|
||
| static final class Handle implements AutoCloseable { | ||
| final Progress type; | ||
| private long value; | ||
| private long startOffset; | ||
| private long endOffset; | ||
|
|
||
| private Handle(Progress type) { | ||
| this.type = type; | ||
| notifyUpdates(this, Type.STARTED); | ||
| } | ||
|
|
||
| void progress(long value, long endValue) { | ||
| progress(value, 0, value, endValue); | ||
| } | ||
|
|
||
| void progress(long counter, long startOffset, long value, long endOffset) { | ||
| // keep this method short so that it can be inlined | ||
| if (counter % 100000 == 0) { | ||
| doProgress(value, startOffset, endOffset); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| notifyUpdates(this, Type.FINISHED); | ||
| } | ||
|
|
||
| private void doProgress(long value, long startOffset, long endOffset) { | ||
| this.value = value; | ||
| this.endOffset = endOffset; | ||
| this.startOffset = startOffset; | ||
| notifyUpdates(this, Type.PROGRESS); | ||
| } | ||
|
|
||
| long getValue() { | ||
| return value; | ||
| } | ||
|
|
||
| long getStartOffset() { | ||
| return startOffset; | ||
| } | ||
|
|
||
| long getEndOffset() { | ||
| return endOffset; | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how bout ?
and then call it like