Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve UI loading #1116

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Feat/improve UI loading #1116

merged 4 commits into from
Jan 3, 2025

Conversation

trungbach
Copy link
Contributor

This pull request includes several updates to improve the efficiency and maintainability of the codebase, particularly focusing on the initialization and usage of the tokenInspector instance, as well as optimizing the loading of components.

Token Inspector Initialization and Usage:

Component Loading Optimization:

  • src/routes.tsx: Refactored to use React's lazy and Suspense for dynamic import of components, improving the initial load time and rendering performance.

Miscellaneous Changes:

  • index.html: Changed the Google Analytics script to load with defer instead of async to ensure it doesn't block other critical resources.
  • src/layouts/App.tsx: Removed the unused import of LoadingPage to clean up the code.
  • src/pages/Balance/index.tsx: Removed commented-out code related to dynamic bridge support for Solana.

Copy link

Deploying beta-oraidex with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec52dfd
Status: ✅  Deploy successful!
Preview URL: https://ffd4912d.beta-oraidex.pages.dev
Branch Preview URL: https://develop-v3.beta-oraidex.pages.dev

View logs

Copy link
Member

@vuonghuuhung vuonghuuhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not Too Bad

@haunv3 haunv3 merged commit 67600e5 into main Jan 3, 2025
3 of 4 checks passed
@haunv3 haunv3 deleted the feat/improve-ui-loading branch January 3, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants