change the Accept header sent to the exporters #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new version of the API endpoint (`/v2`). This new version change the `Accept` HTTP header sent to the exporters requested (from `application/openmetrics-text` … to `text/plain`) because the Go library we use does not seems to support all OpenMetrics specificities ^1. The requests sent to the exporters contains a new HTTP header `X-Promfetcher-API-version` with the Promfetchers API version. ^1: Java actuator does respect the OpenMetrics specifications; the double quotes in the comments is not supported for example: > # HELP process_cpu_usage The \"recent cpu usage\" for the Java Virtual Machine process See also: [1]: prometheus/client_golang#829 (comment) [2]: prometheus/common#214
- v1: `application/openmetrics-text; version=0.0.1,text/plain;version=0.0.4;q=0.5,*/*;q=0.1` - v2: `text/plain; version=0.0.4; charset=utf-8`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the Accept header sent to the exporters
Create a new version of the API endpoint (
/v2) and deprecate/v1.This new version change the
AcceptHTTP header sent to the exporters requested (fromapplication/openmetrics-text… totext/plain) because the Go library we use does not seems to support all OpenMetrics specificities ^1.The requests sent to the exporters contains a new HTTP header
X-Promfetcher-API-versionwith the Promfetchers API version.^1: Java actuator does respect the OpenMetrics specifications; the double quotes in the comments is not supported for example:
See also:
[1]: prometheus/client_golang#829 (comment)
[2]: prometheus/common#214