Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concurrent_map.go #95

Closed
wants to merge 2 commits into from
Closed

Update concurrent_map.go #95

wants to merge 2 commits into from

Conversation

gua-pian
Copy link

@gua-pian gua-pian commented Apr 9, 2021

use the std lib .

@orcaman
Copy link
Owner

orcaman commented Apr 11, 2021

@gua-pian thanks for contributing! Please see the discussion we've had here: #48

The TL:DR; is that we need to include some benchmarks in this repo (go test -bench) to make sure these type of changes do not hurt performance for the users of the package.

Eventually, in the discussion we've had on the stdlib's page here, the native implementation did seem a tad slower, but perhaps it's just the number of test iterations.

@gua-pian
Copy link
Author

@orcaman thanks for your reply, I'll close this.

@gua-pian gua-pian closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants