Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stedy map #56

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Stedy map #56

wants to merge 3 commits into from

Conversation

stedy
Copy link

@stedy stedy commented Mar 17, 2023

Pull request checklist

Please check if your PR 🚀 fulfills the following requirements:

  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [ x] Build (npm run start) was run locally and new changes were working correctly
  • [ x] Lint (npm run linter) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • [x ] Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

I could not get the main branch to build on my local machine so I removed many of the dependencies in an attempt to get it working. After doing so, I mainly focused on the map feature so I refactored the code to use acartia.io API instead of google sheets. There is more to be done for sure but I wanted to make a branch that worked from a fresh install to encourage others to contribute.

Fixes #

What is the new behavior?

Runs using npm start, better map visualization

Does this introduce a breaking change?

  • Yes
  • [ x] No

Checklist_User's_Behalf:

  • Documentation
  • Tests
  • TypeScript Types
  • Ready to be merged

Not sure, does make several major changes (such as abandoning typescript) but hopefully moves this project forward.

Other information

@netlify
Copy link

netlify bot commented Mar 17, 2023

👷 Deploy request for orcamap pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 265515c

@scottveirs scottveirs requested a review from ivanoats March 21, 2023 21:02
@scottveirs
Copy link
Member

Hey @stedy -- I'm not a coder, but am curious: why did you abandon typescript?

@stedy
Copy link
Author

stedy commented Mar 21, 2023

I could not get the repo to run on my local machine so I just started paring it down until I could get it to work. I am not really a web developer (and certainly have nothing against typescript!) but I just wanted to get a map working in a react framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants