Skip to content

Commit

Permalink
fix: reduce orthogonality check threshold
Browse files Browse the repository at this point in the history
  • Loading branch information
YifuTao committed Sep 18, 2024
1 parent 4505404 commit 80d42f1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion oxford_spires_utils/se3.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def is_se3_matrix(se3_matrix):
valid_last_row = np.allclose(se3_matrix[3], [0, 0, 0, 1]) # chec k the last row
R = se3_matrix[:3, :3]
valid_rot_det = np.isclose(np.linalg.det(R), 1.0, atol=1e-6) # check the rotation matrix
valid_orthogonality = np.allclose(R @ R.T, np.eye(3), atol=1e-6) # check the orthogonality
valid_orthogonality = np.allclose(R @ R.T, np.eye(3), atol=1e-5) # check the orthogonality
is_valid = valid_shape and valid_last_row and valid_rot_det and valid_orthogonality
debug_info = {
"valid_shape": valid_shape,
Expand Down

0 comments on commit 80d42f1

Please sign in to comment.