Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IJRR paper submission #13

Merged
merged 83 commits into from
Oct 28, 2024
Merged

IJRR paper submission #13

merged 83 commits into from
Oct 28, 2024

Conversation

YifuTao
Copy link
Collaborator

@YifuTao YifuTao commented Oct 28, 2024

This pull request includes changes done for the IJRR paper evaluation

  • refactor main recon benchmark script. Add evaluation function
  • add yaml config for the reconstruction benchmark script
  • add multi-threshold reconstruction metrics (precision, recall and f-score
  • fix nerf trajectory reader if want to read timestamp
  • add nerf trajectory json handler
  • refactor colmap
  • add nerf json split script (for the out-of-sequence evaluation)
  • refactor nerfstudio colmap symlink: use relative path so that you can access it outside docker too
  • move colmap undistorter from mvs to colmap script
  • add sdfstudio install, and move nerfstudio install to the docker from the requirement.txt due to install conflict

TODO: make the out-of-sequence eval be using the same trajectory json. Currently creates two json

since each sequence will use the same gt
by default we still use nerfstudio
… to docker

this make it easier to manage sdfstudio which uses an older version of nerfstudio
this supports opening symlink outisde docker
more flexible than timestamp selection at removing some outlier images
octomap voxel size too large and it is less accurate
@YifuTao YifuTao merged commit 736f941 into main Oct 28, 2024
2 checks passed
@YifuTao YifuTao deleted the et-dev branch October 28, 2024 09:50
@YifuTao
Copy link
Collaborator Author

YifuTao commented Oct 31, 2024

Note that when evaluating reconstruction in the paper, max distance is not filtered. This is only relevant to nerfacto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant