Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/fix automatic batch size onnx #123

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

lorenzomammana
Copy link
Contributor

Summary

When running the automatic batch size computation using an ONNX backbone for sklear based classification task, if an OOM occoured it is not catched properly causing an unhandled runtime error.

Type of Change

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@lorenzomammana lorenzomammana added the bug Something isn't working label Jun 24, 2024
@lorenzomammana lorenzomammana requested a review from rcmalli June 24, 2024 12:08
@lorenzomammana lorenzomammana self-assigned this Jun 24, 2024
@lorenzomammana lorenzomammana merged commit 4e07340 into main Jun 24, 2024
2 checks passed
@lorenzomammana lorenzomammana deleted the hotfix/fix-automatic-batch-size-onnx branch June 24, 2024 12:20
@lorenzomammana lorenzomammana restored the hotfix/fix-automatic-batch-size-onnx branch June 24, 2024 12:20
@lorenzomammana lorenzomammana deleted the hotfix/fix-automatic-batch-size-onnx branch June 24, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants