restored role-check before hint to create mupro #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VILLAN3LL3
requested changes
Nov 30, 2023
wolfgangroese
force-pushed
the
bug/ARPA-955-put-back-role-condition-in-dashboard-mupro-create-hint
branch
from
4891050 to
29d4e45
Compare
The dashboard initialization code has been refactored for better readability and maintainability. The RxJS operator 'switchMap' has been added to handle async code more efficiently within the 'checkIfUserHasMusicianProfile' method. Additionally, the method 'ngOnInit()' has been cleaned up by extracting its logic into separate, newly created methods.
Significant updates were made to improve the clarity and detail of documentation within the DashboardComponent file. Notably, descriptions were added to CardLayout interface, ArpaWidgetConfigDirective, and WidgetStateService classes. In addition, annotation for the directive and its usage was provided, and a more comprehensive explanation was attached to the DashboardComponent.
wolfgangroese
force-pushed
the
bug/ARPA-955-put-back-role-condition-in-dashboard-mupro-create-hint
branch
from
61cdbea to
8c57497
Compare
…ashboard-mupro-create-hint
…ashboard-mupro-create-hint
wolfgangroese
deleted the
bug/ARPA-955-put-back-role-condition-in-dashboard-mupro-create-hint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not checking the users role caused error "forbidden" when user is admin-role only as musician profile (meService) can only get by performer.