Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tunnel and proxy use dev mode always #388

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat: tunnel and proxy use dev mode always #388

merged 2 commits into from
Oct 17, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 15, 2024

The --dev flag essentially enabled wildcard cors. To make development easier, the flag has been removed and instead we will check if the user supplied specific CORS origins. If they did not, wildcard CORS is enabled.

The Ory Proxy and Ory Tunnel are only supposed to be used during development, so adding a flag --dev seemed pointless.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation within the code base (if
    appropriate).

Further comments

The `--dev` flag essentially enabled wildcard cors. To make development easier, the flag has been removed and instead we will check if the user supplied specific CORS origins. If they did not, wildcard CORS is enabled.

The Ory Proxy and Ory Tunnel are only supposed to be used during development, so adding a flag `--dev` seemed pointless.
@aeneasr aeneasr merged commit 30b10d9 into master Oct 17, 2024
15 checks passed
@aeneasr aeneasr deleted the improve-tunnel branch October 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant