Avoid raising alerts about "Worker has no heartbeat" log messages #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's usually no severe problem, see https://progress.opensuse.org/issues/138536.
perlpunk
reviewed
Aug 7, 2024
| @@ -97,6 +97,7 @@ is-ignored '\[warn\].* Unable to wakeup scheduler: Request timeout' | |||
| is-ignored '\[warn\].* fatal: Invalid revision range .*\.\.' | |||
| is-ignored '\[warn\] \[pid:[0-9]*\] $' | |||
| is-ignored '\[error\].*cmd returned 32768$' | |||
| is-ignored '\[error\] Worker 17519 has no heartbeat \(900 seconds\), restarting \(see FAQ for more\)' | |||
There was a problem hiding this comment.
Changing that to
is-ignored '\[error\] Worker 17519 has no heartbeat'
fails the test.
I suggest to do a very minimal check in the test itself. No need to include the rest of the line. Looking for heartbeat would actually be enough. The \( is probably doing the wrong thing.
perlpunk
added a commit
to perlpunk/openqa-logwarn
that referenced
this pull request
Aug 7, 2024
See os-autoinst#49 The regex to include actually needs to be the last argument
perlpunk
added a commit
to perlpunk/openqa-logwarn
that referenced
this pull request
Aug 7, 2024
See os-autoinst#49 The regex to include actually needs to be the last argument
perlpunk
added a commit
to perlpunk/openqa-logwarn
that referenced
this pull request
Aug 7, 2024
See os-autoinst#49 The regex to include actually needs to be the last argument
Merged
perlpunk
added a commit
to perlpunk/openqa-logwarn
that referenced
this pull request
Aug 7, 2024
See os-autoinst#49 The regex to include actually needs to be the last argument. And the regex in the test wasn't really matching because the escaping of \( is probably wrong, so I reduced that, as in the test we only need to match for the unique thing in our example log.
perlpunk
added a commit
to perlpunk/openqa-logwarn
that referenced
this pull request
Aug 7, 2024
See os-autoinst#49 The regex to include actually needs to be the last argument. And the regex in the test wasn't really matching because the escaping of \( is probably wrong, so I reduced that, as in the test we only need to match for the unique thing in our example log. Issue: https://progress.opensuse.org/issues/165033
perlpunk
added a commit
to perlpunk/openqa-logwarn
that referenced
this pull request
Aug 7, 2024
See os-autoinst#49 The regex to include actually needs to be the last argument. And the regex in the test wasn't really matching because the escaping of \( is probably wrong, so I reduced that, as in the test we only need to match for the unique thing in our example log. Issue: https://progress.opensuse.org/issues/165033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's usually no severe problem, see
https://progress.opensuse.org/issues/138536.