Fix CI failure on Python 3.12 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our setup.py imports setuptools which is no longer provided by Python 3.12. It must be installed manually via pip. We did not notice this because the "nodeenv" package listed setuptools in its install_requires, thus providing the dependency for us. Four hours ago nodeenv 1.9.0 was released, and it happened to drop the setuptools dependency. This broke CI. Add an explicit setuptools requirement in our pip command to fix it. Signed-off-by: Stephen Brennan <[email protected]>
|
The 3.12 failure can be seen in this build. The 3.6 failure for that branch is for a genuine issue with my change, but the 3.12 issue cropped up by chance at the same time. I root-caused it by comparing to this recent build which installed setuptools as a dependency of nodeenv, while my build no longer did. |
osandov
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our setup.py imports setuptools which is no longer provided by Python 3.12. It must be installed manually via pip. We did not notice this because the "nodeenv" package listed setuptools in its install_requires, thus providing the dependency for us.
Four hours ago nodeenv 1.9.0 was released, and it happened to drop the setuptools dependency. This broke CI. Add an explicit setuptools requirement in our pip command to fix it.