Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adds principles to the governance document #77

Merged
merged 4 commits into from
Sep 19, 2024
Merged

docs: adds principles to the governance document #77

merged 4 commits into from
Sep 19, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Sep 3, 2024 •
edited
Loading

Closes #78

@jpower432 jpower432 marked this pull request as ready for review September 3, 2024 17:41
jflowers
jflowers approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@jflowers jflowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vikas-agarwal76
vikas-agarwal76 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuji-watanabe-jp
Copy link
Member

LGTM

degenaro
degenaro approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@degenaro degenaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432
Copy link
Member Author

Merging with over 2/3 reviewer approval

@jpower432 jpower432 merged commit 11e271c into main Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikas-agarwal76 vikas-agarwal76 vikas-agarwal76 approved these changes

@ancatri ancatri ancatri approved these changes

@yuji-watanabe-jp yuji-watanabe-jp yuji-watanabe-jp approved these changes

@degenaro degenaro degenaro approved these changes

@jflowers jflowers jflowers approved these changes

@mrgadgil mrgadgil Awaiting requested review from mrgadgil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add guiding principles to the documentation
6 participants
@jpower432 @yuji-watanabe-jp @jflowers @degenaro @ancatri @vikas-agarwal76