Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to include apac friendly call #91

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

butler54
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
@butler54
Copy link
Contributor Author

Thanks good catch

@butler54 butler54 requested a review from jpower432 November 19, 2024 21:14
@jpower432
Copy link
Member

I think we probably need to look at supporting sign offs for web-based commits.

@butler54
Copy link
Contributor Author

I think we probably need to look at supporting sign offs for web-based commits.

100% - I've squashed out the commits for now.

Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butler54 Looks like some .DS_Store binary files appeared on that last commit.

@butler54 butler54 requested a review from jpower432 November 20, 2024 22:13
@butler54
Copy link
Contributor Author

@butler54 Looks like some .DS_Store binary files appeared on that last commit.

Fixed.

Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 9c0761f into oscal-compass:main Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants