Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display openssf best practices badge #1751

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

degenaro
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro degenaro added this to the v3.6.0 milestone Nov 11, 2024
@degenaro
Copy link
Collaborator Author

@butler54 @jpower432 @AleJo2995 @vikas-agarwal76 Please follow the OpenSSF link and suggest any improvements to the answers submitted, especially the items related to security and analysis. Thx!

@degenaro
Copy link
Collaborator Author

Congratulations!
According to the information that you've provided,
your project has earned the OpenSSF best practices 'passing' badge.
For more information, see this URL:
https://www.bestpractices.dev/en/projects/9408

Please add your badge to your project and/or repository site;
you've earned it:
* In markdown you can add this:
  [![OpenSSF Best Practices]([https://www.bestpractices.dev/projects/9408/badge)](https://www.bestpractices.dev/projects/9408](https://www.bestpractices.dev/projects/9408/badge)%5D(https://www.bestpractices.dev/projects/9408))
* In HTML you can add this:
  <a href="https://www.bestpractices.dev/projects/9408"><img src="https:///projects/9408/badge"></a>

We strongly encourage you to add or improve justification text,
including adding URLs that point to more information.
If you have suggestions on how to improve the criteria or
badge web application, please file an issue at:
https://github.com/coreinfrastructure/best-practices-badge/issues
One of our goals is to encourage projects to make some improvements.
We put some of these reports on the public wiki; please let us know
if you do NOT want the changes publicly posted at
https://github.com/coreinfrastructure/best-practices-badge/wiki/Impacts
Thank you, and congratulations.

--- David A. Wheeler, OpenSSF Best Practices Badge Lead

Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@degenaro Reviewed this and the badge response content. The only comment I had there is that we use Sonar and CodeQL for static analysis and I did not see a mention of CodeQL. I did not identify any other issue.

README.md Outdated Show resolved Hide resolved
@degenaro degenaro requested a review from jpower432 November 13, 2024 19:08
Signed-off-by: Lou DeGenaro <[email protected]>
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to docs/index.md

Signed-off-by: Lou DeGenaro <[email protected]>
@degenaro degenaro requested a review from a team as a code owner November 25, 2024 13:35
@degenaro degenaro requested a review from butler54 November 25, 2024 13:36
@degenaro degenaro merged commit 4a7c123 into develop Nov 26, 2024
14 checks passed
@degenaro degenaro deleted the openssf-badge-display branch November 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants