Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update setup.cfg to change author and email #1767

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: update setup.cfg to change author and email #1767

merged 1 commit into from
Dec 3, 2024

Conversation

vikas-agarwal76
Copy link
Member

@vikas-agarwal76 vikas-agarwal76 commented Dec 3, 2024 •
edited by AleJo2995
Loading

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Updates setup.cfg to change author and email. PyPi picks these details from this file.

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@vikas-agarwal76 vikas-agarwal76 requested a review from a team as a code owner December 3, 2024 16:28
@jpower432 jpower432 linked an issue Dec 3, 2024 that may be closed by this pull request
Update authors information in project metadata to reflect CNCF community #1721
Closed
@vikas-agarwal76 vikas-agarwal76 changed the title fix: Update setup.cfg to change author and email fix: update setup.cfg to change author and email Dec 3, 2024
degenaro
degenaro approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@degenaro degenaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AleJo2995
AleJo2995 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jpower432
jpower432 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikas-agarwal76 vikas-agarwal76 added this to the v3.6.0 milestone Dec 3, 2024
@vikas-agarwal76 vikas-agarwal76 merged commit 700aef4 into develop Dec 3, 2024
16 of 17 checks passed
@vikas-agarwal76 vikas-agarwal76 deleted the vikas-agarwal76-patch-1 branch December 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpower432 jpower432 jpower432 approved these changes

@AleJo2995 AleJo2995 AleJo2995 approved these changes

@degenaro degenaro degenaro approved these changes

@butler54 butler54 Awaiting requested review from butler54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Update authors information in project metadata to reflect CNCF community
4 participants
@vikas-agarwal76 @degenaro @AleJo2995 @jpower432