Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt GAP_ExecuteProcess signature #1131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lgoettgens
Copy link
Member

to pass tests in testinstall/kernel/streams.tst.

Resolves #1012 in the case that use_orig_ExecuteProcess = true, i.e. until #908 is worked on.

to pass tests in `testinstall/kernel/streams.tst`
@lgoettgens lgoettgens requested a review from fingolfin January 24, 2025 15:44
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.75%. Comparing base (be6e4e2) to head (49945b0).

Files with missing lines Patch % Lines
src/exec.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   74.66%   81.75%   +7.09%     
==========================================
  Files          55       50       -5     
  Lines        4713     3821     -892     
==========================================
- Hits         3519     3124     -395     
+ Misses       1194      697     -497     
Files with missing lines Coverage Δ
src/exec.jl 15.00% <50.00%> (ø)

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAP_ExecuteProcess should mimic ExecuteProcess a bit more closely
1 participant