Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weyl_group(::Matrix{<:IntegerUnion}) convenience constructor #4536

Merged

Conversation

lgoettgens
Copy link
Member

Resolves #4473.

cc @TWiedemann

@lgoettgens lgoettgens added enhancement New feature or request topic: LieTheory labels Feb 4, 2025
@lgoettgens lgoettgens requested a review from fingolfin February 4, 2025 12:32
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (069bd41) to head (1736eca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4536      +/-   ##
==========================================
- Coverage   84.41%   84.40%   -0.01%     
==========================================
  Files         672      672              
  Lines       89155    89157       +2     
==========================================
  Hits        75256    75256              
- Misses      13899    13901       +2     
Files with missing lines Coverage Δ
src/LieTheory/RootSystem.jl 88.86% <100.00%> (ø)
src/LieTheory/WeylGroup.jl 92.85% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

@simonbrandhorst simonbrandhorst merged commit e881004 into oscar-system:master Feb 4, 2025
27 of 31 checks passed
@lgoettgens lgoettgens deleted the lg/weyl-group-gcm-Int branch February 4, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: LieTheory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weyl_group constructor for Cartan matrix over Int
2 participants