Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add guide docs for rookify #688

Merged
merged 17 commits into from
Nov 29, 2024
Merged

feat: add guide docs for rookify #688

merged 17 commits into from
Nov 29, 2024

Conversation

boekhorstb1
Copy link
Contributor

@boekhorstb1 boekhorstb1 commented Sep 25, 2024

  • adding docs for rookify: deploy, config and operation guides

Copy link
Contributor

@b1-lender b1-lender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller wording/grammar issues.

docs/guides/operations-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/operations-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/operations-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/operations-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/deploy-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/deploy-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/deploy-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/deploy-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/configuration-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/configuration-guide/rookify.md Outdated Show resolved Hide resolved
boekhorstb1 and others added 14 commits October 8, 2024 10:56
Co-authored-by: b1-lender <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Co-authored-by: b1-lender <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Co-authored-by: b1-lender <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Co-authored-by: b1-lender <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
docs/guides/configuration-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/configuration-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/configuration-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/deploy-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/deploy-guide/rookify.md Show resolved Hide resolved
docs/guides/operations-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/operations-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/operations-guide/rookify.md Outdated Show resolved Hide resolved
docs/guides/operations-guide/rookify.md Show resolved Hide resolved
docs/guides/troubleshooting-guide/rookify.md Outdated Show resolved Hide resolved
Copy link

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change I guess but otherwise than that it looks good for me as well :)

Ensure that you use the correct `data.pickle` file. If you used the pickle file for other setups previously, be sure to delete it.
:::

Rookify's `execution-mode` allows you to run the migration. This a point of no (easy) return. Be sure to check all your configurations. Run `--migrate` or `-m` to execute the migration process.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ... This is a point of no (easy) return ...

Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
Copy link
Contributor Author

ok @berendt , all approved you can take another look if you like

@berendt berendt merged commit 0d7e7d3 into main Nov 29, 2024
3 checks passed
@berendt berendt deleted the rookify-docs branch November 29, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants