Add budgie support #263
Merged
Add budgie support #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0drex
reviewed
Feb 2, 2024
yin_yang/plugins/system.py
Outdated
| def available(self) -> bool: | ||
| return test_gnome_availability(self.command) | ||
|
|
||
| '''Override because budgie uses a switch for dark/light mode''' |
There was a problem hiding this comment.
Please use a comment, or put the docstring after the method declaration with a blank line afterwards
|
If budgie is based on Gnome, then this plugin should work there as well. Can you check if you need this functionality in Yin-Yang? I personally think the plugin is nicer on gnome, since it uses the Adwaita style and not Qt. |
|
I would argue that the functionality is needed. Budgie is straying further from Gnome by the day. They are using gtk themes though. There are no gnome extensions for budgie |
l0drex
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #220