Implement and test file seek, extract common "read_exactly" for reuse #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
osmium::io::detail::PbfParser::read_exactly
as a generic, easily reusable functionosmium::util::file_seek
for random access in files (currently unused, see below)read_exactly
)This works toward #367, which is where
file_seek
will be very useful.If you think
file_seek
should instead live inexperimental
, I'd be happy to move the function there.