-
Notifications
You must be signed in to change notification settings - Fork 82
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updates to Pull Request Template (#324)
* Update PR template * Clarify * add line break
- Loading branch information
Showing
1 changed file
with
10 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,22 @@ | ||
### Description: | ||
|
||
Add description here. | ||
Add a short description of the check here. Link any github issues associated with this PR. | ||
|
||
### Potential Impact: | ||
|
||
List potential impact to downstream libraries here (ex. atlas-checks, atlas-generator) | ||
List potential impact to downstream libraries here (ex. atlas-checks, atlas-generator). | ||
|
||
### Unit Test Approach: | ||
|
||
Describe unit tests being added with that PR. | ||
Describe unit tests being added with this PR. | ||
|
||
### Test Results: | ||
|
||
Describe other (non-unit) test results here. | ||
Describe other (non-unit) test results here. In case of a new check or enhancements to existing | ||
checks, please add details on how many countries the check was tested on, | ||
total flag counts, FP rate etc. (see below example). | ||
|
||
| ISO | Total Flags | Sampled | Sampling % | TP | FP | False Positive Rate | | ||
|-----|-------------|----------|------------|----|----| ------------------- | | ||
| ARE | 109 | 33 | 30% | 24 | 9 | 27% | | ||
|