Skip to content

Commit

Permalink
Updates to Pull Request Template (#324)
Browse files Browse the repository at this point in the history
* Update PR template

* Clarify

* add line break
  • Loading branch information
sayas01 authored Jul 6, 2020
1 parent 2561305 commit fbadff5
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
### Description:

Add description here.
Add a short description of the check here. Link any github issues associated with this PR.

### Potential Impact:

List potential impact to downstream libraries here (ex. atlas-checks, atlas-generator)
List potential impact to downstream libraries here (ex. atlas-checks, atlas-generator).

### Unit Test Approach:

Describe unit tests being added with that PR.
Describe unit tests being added with this PR.

### Test Results:

Describe other (non-unit) test results here.
Describe other (non-unit) test results here. In case of a new check or enhancements to existing
checks, please add details on how many countries the check was tested on,
total flag counts, FP rate etc. (see below example).

| ISO | Total Flags | Sampled | Sampling % | TP | FP | False Positive Rate |
|-----|-------------|----------|------------|----|----| ------------------- |
| ARE | 109 | 33 | 30% | 24 | 9 | 27% |

0 comments on commit fbadff5

Please sign in to comment.