Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/boundary intersection check test #458

Draft
wants to merge 36 commits into
base: dev
Choose a base branch
from

Conversation

Amon-Cyn
Copy link
Contributor

@Amon-Cyn Amon-Cyn commented Jan 3, 2021

Description:

Add a short description of the check here. Link any github issues associated with this PR.

Potential Impact:

List potential impact to downstream libraries here (ex. atlas-checks, atlas-generator).

Unit Test Approach:

Describe unit tests being added with this PR.

Test Results:

Describe other (non-unit) test results here. In case of a new check or enhancements to existing
checks, please add details on how many countries the check was tested on,
total flag counts, FP rate etc. (see below example).

ISO Total Flags Sampled Sampling % TP FP False Positive Rate
ARE 109 33 30% 24 9 27%

@Amon-Cyn Amon-Cyn force-pushed the feature/boundary_intersection_check_test branch 2 times, most recently from 6426287 to 2b2af3f Compare January 3, 2021 20:39
Amon-Cyn and others added 28 commits January 27, 2021 15:32
… Intersection changed to crosses not touches.
@Amon-Cyn Amon-Cyn force-pushed the feature/boundary_intersection_check_test branch from d47bf40 to ae79a97 Compare January 27, 2021 14:33
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant