-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/boundary intersection check test #458
Draft
Amon-Cyn
wants to merge
36
commits into
osmlab:dev
Choose a base branch
from
Amon-Cyn:feature/boundary_intersection_check_test
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/boundary intersection check test #458
Amon-Cyn
wants to merge
36
commits into
osmlab:dev
from
Amon-Cyn:feature/boundary_intersection_check_test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amon-Cyn
force-pushed
the
feature/boundary_intersection_check_test
branch
2 times, most recently
from
January 3, 2021 20:39
6426287
to
2b2af3f
Compare
… Intersection changed to crosses not touches.
Checkstyle ordering fixed
… of area and line. Checkstyle fixed.
… of area and line.
…roblem when incorrect geometry is entered.
Amon-Cyn
force-pushed
the
feature/boundary_intersection_check_test
branch
from
January 27, 2021 14:33
d47bf40
to
ae79a97
Compare
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a short description of the check here. Link any github issues associated with this PR.
Potential Impact:
List potential impact to downstream libraries here (ex. atlas-checks, atlas-generator).
Unit Test Approach:
Describe unit tests being added with this PR.
Test Results:
Describe other (non-unit) test results here. In case of a new check or enhancements to existing
checks, please add details on how many countries the check was tested on,
total flag counts, FP rate etc. (see below example).