Code

Rewrote scripts/unembed-icons.py#2378

Code

Draft

Intrinsica1 wants to merge 20 commits intoosmlab:gh-pagesosmlab/editor-layer-index:gh-pagesfrom Intrinsica1:refactor_unembed-iconsIntrinsica1/editor-layer-index:refactor_unembed-iconsCopy head branch name to clipboard

+202-53

Commits

Commits on Jun 29, 2024

• start refactor on unembed-icons: rename to unembed_icons to conform to PEP 8; start rewrite with getData(url)

  Intrinsica1

  committed
  ae50c1a

  Copy full SHA for ae50c1a

• implement findFile() for just binary data for now

  Intrinsica1

  committed
  c7cee09

  Copy full SHA for c7cee09

• support text data

  Intrinsica1

  committed
  fb7808c

  Copy full SHA for fb7808c

• resolve "TODO: deduplicate reading file"

  Intrinsica1

  committed
  80fe800

  Copy full SHA for 80fe800

• added check counter

  Intrinsica1

  committed
  d2f7241

  Copy full SHA for d2f7241

• stop on invalid mime-type

  Intrinsica1

  committed
  8e6ce95

  Copy full SHA for 8e6ce95

• almost at basic functionality (just missing replacing icon URL in the GeoJSON)

  Intrinsica1

  committed
  4f02fd6

  Copy full SHA for 4f02fd6

• basic functionality!

  Intrinsica1

  committed
  831e3a6

  Copy full SHA for 831e3a6

• add note

  Intrinsica1

  committed
  2159e0b

  Copy full SHA for 2159e0b

• add another note

  Intrinsica1

  committed
  5af58c3

  Copy full SHA for 5af58c3

• extra comments

  Intrinsica1

  committed
  1c2ee13

  Copy full SHA for 1c2ee13

• add comments

  Intrinsica1

  committed
  4af8de1

  Copy full SHA for 4af8de1

• even more comments

  Intrinsica1

  committed
  80af05b

  Copy full SHA for 80af05b

• edit & add comments

  Intrinsica1

  committed
  efc7ccc

  Copy full SHA for efc7ccc

Commits on Jun 30, 2024

• ignore directories and hidden files when searching for icons + support invalid mime types

  Intrinsica1

  committed
  5166fc2

  Copy full SHA for 5166fc2

• handle canceling of Selection and Save As dialogs

  Intrinsica1

  committed
  9daf9af

  Copy full SHA for 9daf9af

• gracefully handle if getData(url) returns None

  Intrinsica1

  committed
  b4f0d51

  Copy full SHA for b4f0d51

• confirm overwrites (now in a broken state)

  Intrinsica1

  committed
  c59f546

  Copy full SHA for c59f546

• return bools

  Intrinsica1

  committed
  449805c

  Copy full SHA for 449805c

• more bools (has been in a working state since last commit)

  Intrinsica1

  committed
  eed7cb7

  Copy full SHA for eed7cb7