Added some Israel chains #10499
Added some Israel chains #10499
Conversation
Snowysauce
added
add brand
| @@ -10670,6 +10670,7 @@ | |||
| "displayName": "יינות ביתן", | |||
| "id": "yeinotbitan-6b65f1", | |||
| "locationSet": {"include": ["il"]}, | |||
| "matchNames": ["yaynot bitan"], | |||
| "tags": { | |||
| "alt_name:en": "Yenot Bitan; Bitan Wines", | |||
There was a problem hiding this comment.
Please remove space after semicolon
There was a problem hiding this comment.
hi, thanks for review!
Where is this space? I don't see it
There was a problem hiding this comment.
The space following the semicolon is in the value for alt_name:en. Semicolons separating values of keys should not have a space following them per OSM conventions.
| "id": "foxhome-a5093f", | ||
| "locationSet": {"include": ["il"]}, | ||
| "id": "foxhome-43585e", | ||
| "locationSet": {"include": ["ca", "il"]}, |
There was a problem hiding this comment.
The Canadian stores should probably have a separate entry in the NSI that doesn't include the multilingual name tags. Also, the specified Wikidata item currently does not have any statements related to stores outside of Israel.
| "displayName": "Laline", | ||
| "id": "laline-255338", | ||
| "locationSet": { | ||
| "include": ["ca", "ge", "il", "jp", "tw"] |
There was a problem hiding this comment.
This locationSet is highly problematic considering that each of the five countries listed not only have different primary languages, but different language scripts. If the brand does indeed operate in these countries, each country should probably have its own localized entry in the NSI.
Hi
Added some more Israeli chains and aligned some existing ones