tests: Remove cross_staking mock #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawoznia
force-pushed
the
remove_cross_staking_mock
branch
2 times, most recently
from
0bcf1ae to
193c40d
Compare
…emaining_tests tests: Remove cross_staking mock from vault tests
Comment on lines
493
to
494
| #[msg(exec)] | ||
| fn test_rollback_unstake(&self, ctx: ExecCtx, tx_id: u64) -> Result<Response, ContractError> { |
There was a problem hiding this comment.
If we are keeping these test helpers for now, could we move them to a separate file? They make the contracts harder to read. Ideally I would love to get rid of them, but if not a separate file would be nice.
There was a problem hiding this comment.
I would love to get rid of them.
For now we could go with something like that: #117. Naming is bad I know.
The best workaround from sylvia side might be to add ability to conditionally use messages attribute.
Something like that would expose interface methods only if mt feature is enabled.
#[contract]
#[mt(messages(interface))]There was a problem hiding this comment.
Approach in #117 is definitely an improvement.
Love the idea of adding the ability to conditionally use messages attribute to sylvia.
maurolacy
approved these changes
Aug 31, 2023
Co-authored-by: Mauro Lacy <[email protected]>
feat: Move ibc workaround methods in ExternalStaking to interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #95