Skip to content

Commit

Permalink
Add todo for is_diff
Browse files Browse the repository at this point in the history
Signed-off-by: methylDragon <[email protected]>
  • Loading branch information
methylDragon committed Nov 21, 2023
1 parent 5ea5ad5 commit bbc07ce
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions nexus_motion_planner/src/motion_plan_cache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,13 @@ MotionPlanCache::extract_and_append_plan_start_to_query(
// I think if is_diff is on, the joint states will not be populated in all
// of our motion plan requests? If this isn't the case we might need to
// apply the joint states as offsets as well.
//
// TODO: Since MoveIt also potentially does another getCurrentState() call
// when planning, there is a chance that the current state in the cache
// differs from the state used in MoveIt's plan.
//
// When upstreaming this class to MoveIt, this issue should go away once
// the class is used within the move group's Plan call.
moveit::core::RobotStatePtr current_state = move_group.getCurrentState();
if (!current_state)
{
Expand Down Expand Up @@ -686,6 +693,13 @@ MotionPlanCache::extract_and_append_plan_start_to_metadata(
// I think if is_diff is on, the joint states will not be populated in all
// of our motion plan requests? If this isn't the case we might need to
// apply the joint states as offsets as well.
//
// TODO: Since MoveIt also potentially does another getCurrentState() call
// when planning, there is a chance that the current state in the cache
// differs from the state used in MoveIt's plan.
//
// When upstreaming this class to MoveIt, this issue should go away once
// the class is used within the move group's Plan call.
moveit::core::RobotStatePtr current_state = move_group.getCurrentState();
if (!current_state)
{
Expand Down Expand Up @@ -1215,6 +1229,13 @@ MotionPlanCache::extract_and_append_cartesian_plan_start_to_query(
// I think if is_diff is on, the joint states will not be populated in all
// of our motion plan requests? If this isn't the case we might need to
// apply the joint states as offsets as well.
//
// TODO: Since MoveIt also potentially does another getCurrentState() call
// when planning, there is a chance that the current state in the cache
// differs from the state used in MoveIt's plan.
//
// When upstreaming this class to MoveIt, this issue should go away once
// the class is used within the move group's Plan call.
moveit::core::RobotStatePtr current_state = move_group.getCurrentState();
if (!current_state)
{
Expand Down Expand Up @@ -1418,6 +1439,13 @@ MotionPlanCache::extract_and_append_cartesian_plan_start_to_metadata(
// I think if is_diff is on, the joint states will not be populated in all
// of our motion plan requests? If this isn't the case we might need to
// apply the joint states as offsets as well.
//
// TODO: Since MoveIt also potentially does another getCurrentState() call
// when planning, there is a chance that the current state in the cache
// differs from the state used in MoveIt's plan.
//
// When upstreaming this class to MoveIt, this issue should go away once
// the class is used within the move group's Plan call.
moveit::core::RobotStatePtr current_state = move_group.getCurrentState();
if (!current_state)
{
Expand Down

0 comments on commit bbc07ce

Please sign in to comment.