AddNote and EditNote Screen Scroller Adjuster #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shimmering the image
Shimmer effects
… is first loaded, it only shows one screen worth of text
… the size of the richTextEditor based on the content of the note
AndchooChen
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138
What was changed?
The files that were changed are the AddNoteScreen and the EditNoteScreen. Specifically the content of the return.
Why was it changed?
The issue with the current way things were was that when the editor had too much content, then it would have a difficult time showing everything that was inside of the rich editor. Thus, the way we will have to show it is by extending the editor to be large enough to show a good amount of the note.
How was it changed?
In the files stated above, the changes included increasing the overall size of the RichEditor and then also cleaning the code in areas that made that section convoluted.
Screenshots that show the changes (if applicable):