separated js from html (WIP) #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also worth noting that I consolidated the tools.js code into playground.js, since these two files had overlapping code it made more sense to consolidate them. |
alar12
requested changes
Nov 30, 2024
There was a problem hiding this comment.
The JavaScript code in the HTML files on the main branch has already been moved to their respective JavaScript files. Before starting work on the issue, make sure to pull the latest changes from the main branch. Write any new JavaScript code in the appropriate external JS files and avoid including it directly in the HTML files.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #43
What is done:
The "Recently Used" section displays manifest Uri's in a card view format
Each card contains: Title, Number of Items, and Image.
Cards are response and visually consistent with the application's existing UI
Below is a screenshot of the card view implementation:
I have completely moved all javaScript code to respective js files, however it has broken the recently used manifests dropdown and tools no longer appear. I have tried make the dropdown functions global, have messed around with their implementations, messed around with how they are called, cannot find a way to fix the dropdown not working without rolling back my changes of removing the javascript code from tools.html. The tools appeared prior to me removing the js code from tools.html, haven't been able to nail down why this is happening either.